Skip to content

Disable all new keywords behind a feature flag#21353

Closed
NullVoxPopuli wants to merge 3 commits intomainfrom
nvp/feature-flag-new-keywords
Closed

Disable all new keywords behind a feature flag#21353
NullVoxPopuli wants to merge 3 commits intomainfrom
nvp/feature-flag-new-keywords

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented May 1, 2026 •
edited
Loading

  • existing process is why this is happening - reason is noble tho -- the team needs to sign off on the behavior via each of the advancement RFCs
  • the exports can't be feature flagged, so those would still be able to be imported
    • I could do a dynamic assignment based on feature flag, and export that, but I don't think we should -- it bloats the code, and I'm trying to delete code (not part of this effort, but in other PRs)

I don't even really know if this PR is needed, because I want all of these available in the next minor anyway

kategengler
kategengler reviewed May 1, 2026
View reviewed changes
Comment thread packages/@ember/canary-features/index.ts Outdated

export const DEFAULT_FEATURES = {
// FLAG_NAME: true/false
NEW_KEYWORDS_2026_05: true,
Copy link
Copy Markdown
Member

@kategengler kategengler May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false by default.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026 •
edited
Loading

📊 Package size report — dist/dev   -0.1%↓

File Before (Size / Brotli) After (Size / Brotli)
dist/dev/packages/@ember/helper/index.js 18.7 kB / 4.9 kB 1%↑18.9 kB / 0.5%↑5 kB
dist/dev/packages/@ember/template-compiler/lib/plugins/auto-import-builtins.js 2.7 kB / 533 B -88.5%↓314 B / -65.3%↓185 B
Total (Includes all files) 2 MB / 476.3 kB -0.1%↓2 MB / -0.07%↓476 kB

📊 Package size report — dist/prod   -0.11%↓

File Before (Size / Brotli) After (Size / Brotli)
dist/prod/packages/@ember/helper/index.js 18.6 kB / 4.9 kB 1%↑18.8 kB / 0.4%↑4.9 kB
dist/prod/packages/@ember/template-compiler/lib/plugins/auto-import-builtins.js 2.7 kB / 533 B -88.5%↓314 B / -65.3%↓185 B
Total (Includes all files) 1.9 MB / 436 kB -0.11%↓1.9 MB / -0.07%↓435.7 kB

Tarball size: 1.2 MB (was 1.2 MB, -198 B)

🤖 This report was automatically generated by pkg-size-action

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

NullVoxPopuli commented May 1, 2026

I don't know how to feature flag any of this.

this is a build plugin, so I'd have to actually just delete all the tests, else we get build errors and can't even boot up the tests due to things not being in scope if we feature flag the traditional way.

The new keywords are not runtime behavior, but build behavior

@NullVoxPopuli NullVoxPopuli deleted the nvp/feature-flag-new-keywords branch May 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kategengler kategengler kategengler left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NullVoxPopuli @kategengler